Reverting get_previous_version logic to get the first tag_name's value from json - #902
Merged
Samruddhi Khandale (samruddhikhandale) merged 5 commits intoMar 15, 2024
Conversation
Samruddhi Khandale (samruddhikhandale)
requested changes
Mar 11, 2024
Samruddhi Khandale (samruddhikhandale)
approved these changes
Mar 11, 2024
Samruddhi Khandale (samruddhikhandale)
left a comment
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
Nice 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features names:
Description:
This PR corrects the existing code with the following functionality:
kubectl-helm-minikubefeature was picking up the second to latest tag from json array of releases url, now have changed that to pick the first value fortag_namekey in the same.Changelog:
install.shfileChecklist: